Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/modal #20

Merged
merged 10 commits into from
Jan 11, 2024
Merged

Feature/modal #20

merged 10 commits into from
Jan 11, 2024

Conversation

Huib8
Copy link
Collaborator

@Huib8 Huib8 commented Dec 21, 2023

de modal waar je aan de zijkant klikt om te laten verdwijnen met een achtergrond die ook verdwijnt

@Huib8 Huib8 requested review from Timtendo12, Chrinsieboy and DanericNetwork and removed request for Timtendo12 December 21, 2023 11:02
Chrinsieboy
Chrinsieboy requested changes Dec 21, 2023
View reviewed changes
src/resources/vue/components/add-line.svg Outdated Show resolved Hide resolved
src/resources/vue/components/arrow-go-back-fill.svg Outdated Show resolved Hide resolved
src/resources/vue/components/close.png Outdated Show resolved Hide resolved
src/resources/vue/components/model.vue Outdated Show resolved Hide resolved
src/resources/vue/components/model.vue Outdated Show resolved Hide resolved
src/resources/vue/components/model.vue Outdated Show resolved Hide resolved
src/resources/vue/components/model.vue Outdated Show resolved Hide resolved
src/resources/vue/scss/global.scss Outdated Show resolved Hide resolved
Chrinsieboy
Chrinsieboy requested changes Dec 21, 2023
View reviewed changes
src/resources/vue/components/model.vue Outdated Show resolved Hide resolved
src/resources/vue/components/model.vue Outdated Show resolved Hide resolved
src/resources/vue/components/model.vue Outdated Show resolved Hide resolved
src/resources/vue/components/model.vue Outdated Show resolved Hide resolved
@Chrinsieboy Chrinsieboy changed the title Feature/model Feature/modal Jan 8, 2024
DanericNetwork
DanericNetwork requested changes Jan 10, 2024
View reviewed changes
Copy link
Owner

@DanericNetwork DanericNetwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments chris made, i've added some more info to his comments

Chrinsieboy
Chrinsieboy requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@Chrinsieboy Chrinsieboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 points 🙈
But on the good path

src/resources/vue/components/model.vue Outdated Show resolved Hide resolved
src/resources/vue/pages/index.vue Outdated Show resolved Hide resolved
Chrinsieboy
Chrinsieboy requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@Chrinsieboy Chrinsieboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw over the head (lekker engels)

src/resources/vue/components/add-line.svg Outdated Show resolved Hide resolved
src/resources/vue/components/arrow-go-back-fill.svg Outdated Show resolved Hide resolved
src/resources/vue/components/close.png Outdated Show resolved Hide resolved
@Chrinsieboy Chrinsieboy added the enhancement New feature or request label Jan 10, 2024
@Huib8 Huib8 requested a review from Chrinsieboy January 10, 2024 14:23
Timtendo12
Timtendo12 requested changes Jan 11, 2024
View reviewed changes
src/resources/vue/components/icon.vue Outdated Show resolved Hide resolved
Chrinsieboy
Chrinsieboy previously approved these changes Jan 11, 2024
View reviewed changes
Timtendo12
Timtendo12 previously approved these changes Jan 11, 2024
View reviewed changes
@Huib8 Huib8 dismissed stale reviews from Timtendo12 and Chrinsieboy via 1e03707 January 11, 2024 12:07
Timtendo12
Timtendo12 previously approved these changes Jan 11, 2024
View reviewed changes
src/resources/vue/components/modal.vue Show resolved Hide resolved
Chrinsieboy
Chrinsieboy previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@Chrinsieboy Chrinsieboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

DanericNetwork
DanericNetwork previously approved these changes Jan 11, 2024
View reviewed changes
@Huib8 Huib8 dismissed stale reviews from DanericNetwork, Chrinsieboy, and Timtendo12 via bf85e97 January 11, 2024 14:22
Chrinsieboy
Chrinsieboy approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@Chrinsieboy Chrinsieboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Nice

@DanericNetwork DanericNetwork merged commit a287236 into dev Jan 11, 2024
1 check passed
@DanericNetwork DanericNetwork deleted the feature/model branch January 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chrinsieboy Chrinsieboy Chrinsieboy approved these changes

@DanericNetwork DanericNetwork DanericNetwork approved these changes

@Timtendo12 Timtendo12 Timtendo12 left review comments

Assignees

@Huib8 Huib8

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Huib8 @Timtendo12 @DanericNetwork @Chrinsieboy